Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover does not close on PopoverButton click on Safari (macOS & iOS) #115

Open
Robin-w151 opened this issue Sep 2, 2022 · 2 comments
Open

Comments

@Robin-w151
Copy link

Describe the bug
When the parent element of a Popover component is focusable (e.g. div with tabindex), the Popover won't close if the PopoverButton is clicked.

Affected browser: Safari (macOS & iOS)

To Reproduce
REPL

Library version
1.0.2

@Robin-w151
Copy link
Author

When playing around with the REPL, I discovered that on Safari the PopoverButton receives focus on every click, thus the Popover is briefly closed and then opened again. I assume that Safari transfers the focus to the parent element and then again to the button element, thus a new focus event is triggered on every click.

@ondrejjcizek
Copy link

How can I contribute in this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants