From 6eb960c362d8eb45fed7282847d326a281aca95a Mon Sep 17 00:00:00 2001 From: rhysd Date: Fri, 16 Jul 2021 12:29:09 +0900 Subject: [PATCH] dump errors to debug log which were found in cleanup --- rule_pyflakes.go | 4 +++- rule_shellcheck.go | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/rule_pyflakes.go b/rule_pyflakes.go index f93e1a502..1febc8af8 100644 --- a/rule_pyflakes.go +++ b/rule_pyflakes.go @@ -116,7 +116,9 @@ func (rule *RulePyflakes) VisitStep(n *Step) error { // Cleanup is callback when visiting finished. This callback is called even if the visiting failed since some callback returned an error func (rule *RulePyflakes) Cleanup() { - rule.group.Wait() // Ensure all processes ended + if err := rule.group.Wait(); err != nil { // Ensure all processes ended + rule.debug("error found while cleanup: %s", err) + } } func (rule *RulePyflakes) isPythonShell(r *ExecRun) bool { diff --git a/rule_shellcheck.go b/rule_shellcheck.go index 065e35511..3e78c4267 100644 --- a/rule_shellcheck.go +++ b/rule_shellcheck.go @@ -124,7 +124,9 @@ func (rule *RuleShellcheck) VisitWorkflowPost(n *Workflow) error { // Cleanup is callback when visiting finished. This callback is called even if the visiting failed since some callback returned an error func (rule *RuleShellcheck) Cleanup() { - rule.group.Wait() // Ensure all processes ended + if err := rule.group.Wait(); err != nil { // Ensure all processes ended + rule.debug("error found while cleanup: %s", err) + } } func (rule *RuleShellcheck) getShellName(exec *ExecRun) string {