Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionlint internal filter cant find the correct uses #304

Closed
prisis opened this issue Jun 8, 2023 · 1 comment
Closed

actionlint internal filter cant find the correct uses #304

prisis opened this issue Jun 8, 2023 · 1 comment

Comments

@prisis
Copy link

prisis commented Jun 8, 2023

It looks like the current filter implemantation cant find the correct skip, if the action use a hash as a number

Example:

Works:

on: push

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: dorny/paths-filter@v2
        id: filter
        with:
          filters: ...
      - run: npm run lint:md
        if: ${{ steps.filter.outputs.md == 'true' }}

Does not work

on: push

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: "dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50"  # v2.11.1
        id: filter
        with:
          filters: ...
      - run: npm run lint:md
        if: ${{ steps.filter.outputs.md == 'true' }}

After the switch to the hash, im currently hitting #18 again

@prisis
Copy link
Author

prisis commented Jun 8, 2023

Okay, looks like i forgot to add

needs: "files-changed" to the next step, the error was just a different one, will close it, because the filter are working

@prisis prisis closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant