Add several google-github-actions etc to generate-popular-actions list #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the most fundamental-looking of the google-github-actions organisation's pinned actions repositories. Also adds pypa/gh-action-pypi-publish as it is important in the Python ecosystem, and pulumi/actions for those using this deployment tool.
rhysd
approved these changes
Feb 14, 2024
|
@jmarshall hey, my action |
webknjaz
added a commit
to aio-libs/yarl
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration, this adds several probably commonly used actions to the list of known actions.
In particular, it was common to use
service_account_keywith google-github-actions/setup-gcloud@v0 to do simple token-via-a-secret authentication. However google-github-actions/setup-gcloud@v1 ignores this option and wants that style of authentication to be expressed in a different way. So for people updating workflows that use setup-gcloud, it's very useful for actionlint to detect the error that will result from just applyings/@v0/@v1/.We use setup-gcloud and auth ourselves; the four I've added here are the most fundamental-looking of the google-github-actions organisation's pinned actions repositories.
I've taken the liberty of also adding pypa/gh-action-pypi-publish as it is important in the Python ecosystem, and pulumi/actions for those using this deployment tool. Those could certainly be dropped from this PR if you didn't want to bloat the popular list with them.