Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert RclRef into GitHub Action #84

Closed
1 of 2 tasks
WoelkiM opened this issue Mar 29, 2021 · 6 comments
Closed
1 of 2 tasks

Insert RclRef into GitHub Action #84

WoelkiM opened this issue Mar 29, 2021 · 6 comments

Comments

@WoelkiM
Copy link
Collaborator

WoelkiM commented Mar 29, 2021

Insert and run RclRef tests and RclBench.

  • RclRef tests
  • RclBench
@WoelkiM
Copy link
Collaborator Author

WoelkiM commented Mar 29, 2021

Problems with Erlang version 21. The current ct are only executed under version 22, 23.

@WoelkiM
Copy link
Collaborator Author

WoelkiM commented Mar 29, 2021

Possible bench implementation:

- name: Checkout repo bench
  uses: actions/checkout@v2
  with:
    repository: riak-core-lite/rcl_bench
    path: ./rcl_bench/

- name: start bench
  run: |
    cd rclref
    make devrel 
    make devrel-start
    make devrel-join
    make devrel-cluster-plan
    make devrel-cluster-commit
    cd ../rcl_bench
    make run

Problem: {error, "Incomplete form (missing .)??"}; See: (rotaki/rclref#6)

@marianoguerra
Copy link
Member

at some point doing rpc eval calls to a node from the command line changed from requiring a dot at the end to not requiring it, maybe in 21 the dot is required?

@WoelkiM
Copy link
Collaborator Author

WoelkiM commented Mar 30, 2021

This is quite possible, but for me the error occurred with Erlang version 23. I will check how it behaves under 21.

edit: The error message under Erlang 21:
escript: exception error: undefined function rebar3:main/1
in function escript:run/2 (escript.erl, line 758)
in call from escript:start/1 (escript.erl, line 277)
in call from init:start_em/1
in call from init:do_boot/3
make: *** [ct] Error 127
Makefile:47: recipe for target 'ct' failed

@WoelkiM
Copy link
Collaborator Author

WoelkiM commented Apr 7, 2021

When running make devrel the problem is that in github actions unfortunately an error occurs.
example commit link(my fork): "connect rcl_bench Erlang CI #43" (Erlang 23)
"mkdir -p _build/dev3/rel/rclref/../rclref_config
/__w/_temp/1c3e05fd-8a1d-4484-a65b-7277e1c164b5.sh: 2: /__w/_temp/1c3e05fd-8a1d-4484-a65b-7277e1c164b5.sh: : not found"

This error did not occur in the previous executions and I can't understand why it occurs now. My thoughts are that either connections are no longer there or old files/processes are not terminated correctly. Unfortunately I haven't found a solution yet.

@albsch
Copy link
Member

albsch commented Jul 12, 2021

We add a new issue for rcl_bench and close this one.

@albsch albsch closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants