Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negative unallocated students message is confusing #19

Open
alexholcombe opened this issue Jan 31, 2022 · 0 comments
Open

negative unallocated students message is confusing #19

alexholcombe opened this issue Jan 31, 2022 · 0 comments
Assignees
Labels

Comments

@alexholcombe
Copy link
Contributor

Line 289 of studentAllocation.vue, below, yields a very confusing message when there are more spaces (say, 10) than there are students (say, 2). Then because ${minUnallocated} == -2, the user will get a message saying "At least -2 students will be unallocated." Easy to fix - sorry I didn't do it but I didn't manage to get the repo to compile from source on my machine (can't remember which library I had trouble with).

   this.log([`***** Total effective cap is ${this.totalCap} spaces for students. At least ${minUnallocated} students will be unallocated`])
@richarddmorey richarddmorey self-assigned this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants