Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compress_fst() in the RDS driver? #110

Open
wlandau opened this issue Jun 18, 2019 · 2 comments
Open

Use compress_fst() in the RDS driver? #110

wlandau opened this issue Jun 18, 2019 · 2 comments

Comments

@wlandau
Copy link
Contributor

wlandau commented Jun 18, 2019

Re #109 (comment) and #109 (comment), I think we could use compress_fst() + saveRDS(compress = FALSE) and see large speed improvements. All we need is a new compress_fst argument to storr_rds() and a tiny bit of logic. PR forthcoming. Should be much easier than #103, #108, and #109. Thanks @MarcusKlik for the idea!
@wlandau wlandau mentioned this issue Jun 18, 2019
Open
@wlandau
Copy link
Contributor Author

wlandau commented Jun 18, 2019

Hmm... should we use the existing compress argument for this?

@nettoyoussef nettoyoussef mentioned this issue Jun 18, 2019
Closed
4 tasks
wlandau-lilly added a commit to wlandau/storr that referenced this issue Jun 18, 2019
@wlandau-lilly
Fix richfitz#110
482244b
@wlandau wlandau mentioned this issue Aug 4, 2019
Closed
2 tasks
@kendonB
Copy link
Contributor

kendonB commented Sep 5, 2019

The package qs might also be useful as a backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlandau @kendonB