Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider maximum logic per line not max line length #3

Open
rigelrozanski opened this issue Nov 30, 2018 · 0 comments
Open

Consider maximum logic per line not max line length #3

rigelrozanski opened this issue Nov 30, 2018 · 0 comments

Comments

@rigelrozanski
Copy link
Owner

Having started reflecting on line lengths and code aesthetics intensely over the past while. I no longer believe the optimal solution actually contains "one size fits all" maximum line length. For instance I think that in specific situations, code can actually be much clearer when it is more compact and thus should allow for greater than 100 character lines. One key example of this is struct definition, where we provide a comment for each field on the line of the field and allow it to. I think what's important in this situation is there there is very little logic on each of these lines, Thus I could see it appropriate that these line lengths actually extend to 140 character. I think a better "max size" might be for the maximum amount of logic per line not the maximum character length.

Anyways, I no-longer think this issue's proposal is a good idea, I've started parsing out the thesis of what I know to be the optimal code aesthetic linting ruleset here: https://github.com/rigelrozanski/aes-fmt (still very much a WIP and developing ideas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant