Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit generated bindings to repo #48

Open
notmgsk opened this issue Oct 26, 2023 · 0 comments
Open

Commit generated bindings to repo #48

notmgsk opened this issue Oct 26, 2023 · 0 comments

Comments

@notmgsk
Copy link
Contributor

notmgsk commented Oct 26, 2023

We would like to make the Python UX as easy as possible. One issue we will have is with pyQuil: we want uses to be able to use pyQuil with or without libquil available. If libquil is installed on their system and they want to use it -- awesome. But if libquil is not available on their system, they should still be able to pip install pyquil without issue.

The problem arises in this situation:

  • user runs pip install pyquil
  • pyquil depends on qcs-sdk-python
  • qcs-sdk-python will need to be compiled with libquil support (as there is no way to configure this with the Python package system)
  • qcs-sdk-python will look for libquil.h in order to generate its bindings

If the user has not installed libquil, the final step will fail.

One way I see around this is to remove the need to generate the bindings at compile time, by having them stored in the libquil-sys repo. We have done this in other projects: in build.rs support a feature flag which turns on the binding generator if they need to be regenerated. Otherwise, the bindings are loading from the repo (with include_file!()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant