Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibrationSet equality should be sensitive to ordering. #356

Closed
MarquessV opened this issue Apr 16, 2024 · 0 comments · Fixed by #357
Closed

CalibrationSet equality should be sensitive to ordering. #356

MarquessV opened this issue Apr 16, 2024 · 0 comments · Fixed by #357

Comments

@MarquessV
Copy link
Contributor

#352 made CalibrationSet equality insensitive to ordering. Per Kalan's follow-up, calibration order should be taken into account, as ordering determines precedence when multiple calibrations match the same instruction. The example:

DEFCAL A(%x, pi):
   ...

DEFCAL A(pi, %x):
   ...

A(pi, pi) # expands into one or the other based on ordering
@MarquessV MarquessV changed the title CalibrationSet equality _should_ be sensitive to ordering. CalibrationSet equality should be sensitive to ordering. Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant