🌙 Dark mode #100
Open
🌙 Dark mode #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go merge ! 😍 |
|
It looks like you made the Dark Mode colors uniform. Right now we use a combination of "OLED Dark Mode" and "Grey Dark Mode". It looks like you went with a full "Grey Dark Mode". Maybe we should have a global setting for "OLED Dark Mode" toggled on and off for pure blacks or your grey dark mode. What do you think @romaintalleu? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on iOS 12.3.1, iOS 14.4 & iPadOS 14.3
Please test all screens and tell me if have missing screens and if necessary change colour for the dark mode. 😄