Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated portions are in simplified Chinese #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holton-jiang
Copy link

@holton-jiang holton-jiang commented Dec 9, 2024

Mark the type contribution you are making:

  • Experimental feature (new functionality that can be selectively enabled/disabled)
  • Bug fix (non-breaking change which fixes an issue)

Description

Summary of your changes, including:

  • Why is this change necessary?
    I want players to be able to understand the interface without the help of translation software
  • Why did you decide on this solution?
    I don't know how to translate it, but I look for string as much as I can

Testing

List all iOS versions and devices you've tested this change on.

Example Configurations:

  • iPhone 13, iOS 18.1.1

Checklist

General (All PRs)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I've tested my changes with different device + OS version configurations

Experimental Feature-specific

  • Added property to ExperimentalFeatures struct annotated with @Feature
  • Uses @Option's to persist all feature-related data
  • Locked all behavior changes behind ExperimentalFeatures.shared.[feature].isEnabled runtime check
  • Isolates changes to separate files as much as possible (e.g. via Swift extensions)

@holton-jiang holton-jiang changed the title Translate parts of the content Translated portions are in simplified Chinese Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant