-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed breaking changes for Mapperly 4.0 #1131
Comments
What is the justification of no. 3? |
@wrestlerdude the idea is to get to a more explicit API and prevent accidental / non-intuitive use of a mapping method by Mapperly. |
Why do you consider changing the severity to Warning a breaking change on no. 1? Am I missing something? 🤔 |
It is not really a breaking change, but we decided to postpone this change to the next major release since it may still need adjustments by all users that have |
We decided to not implement 3), 4) and 5) for now to keep breaking changes limited. All other breaking changes are merged. |
A list of proposed breaking changes for Mapperly 4.0:
To be discussed, if a particular change on the list leads to major discussions, we should create a separate issue.
1.1. Change the default severity of
RMG012: Source member was not found for target member
toWarning
1.2. Change the default severity of
RMG020: Source member is not mapped to any target member
toWarning
1.3. Change the default severity of
RMG037: An enum member could not be found on the source enum
toWarning
1.4. Change the default severity of
RMG038: An enum member could not be found on the target enum
toWarning
MapPropertyAttribute.ctor(string[], string[])
withMapPropertyAttribute.ctor(string, string[])
andMapPropertyAttribute.ctor(string[], string)
since member paths are only supported on one side by Mapperly (Replace invalid MapPropertyAttribute constructors with valid versions #1354).MapperAttribute.AutoUserMappings
tofalse
.MapperAttribute.PreferParameterlessConstructors
tofalse
RMG060: Multiple user mappings discovered without specifying an explicit default
toError
(requiresMapperAttribute.AutoUserMappings
default tofalse
due to Before/After-Map).ExplicitCast
to a newEnumUnderlayingType
conversion (Option to disable EnumUnderlayingType conversions #1176, add enum underlying type conversion #1352)The text was updated successfully, but these errors were encountered: