riot.compile() troubles parsing HTML files

[nippur72]

Working with the compiler, I noticed that it often fails to parse HTML correctly.

See for example this JsFiddle:

<my-tag>   
   <div>
      <child-tag data={data}></child-tag> 
   </div>    
</my-tag>

compiles into:

riot.tag('my-tag', '<div>', function(opts) {
     <child-tag data={data}></child-tag> 
  </div>    

});

Is this an expected beaviour? The docs say tags have to be indented (and they are) and tag definition must start at beginning of line (and it does). Also there are no tabs, just spaces and newlines.

[GianlucaGuarini]

Riot is indentation sensitive, it seems your html string is not correctly indented, this is the correct one http://jsfiddle.net/jc2ywhfv/2/

[nippur72]

do you mean indented exactly by just two spaces? It seems a rather restrictive requirement.

At least I suggest to state it clearly in the docs, not everybody use this indentation rule on HTML.

[GianlucaGuarini]

I mean that this:

<my-tag>   <!-- tralling spaces -->
   <div>
      <child-tag data={data}></child-tag> <!-- tralling spaces -->
   </div>    <!-- tralling spaces -->
</my-tag>

is not a valid riot markup, maybe @aMarCruz could fix this issue in the new upcoming compiler with riot 2.3.0

[aMarCruz]

Will be fixed in 2.3.0

[aMarCruz]

Ok, this was (partially) fixed in 2.3.0, but we have two different behaviors and one bug, depending on where the tag is defined.

Trailing comments and spaces inside custom tags are removed in both external .tag files and inlined tags.

Indentation is the problem. Beta versions of the compiler 2.3 worked with any indentation, but in the last phase this changed to support treeview-like constructions, such as in this file and now, again, zero indentation is a requirement.

Even more, in some parts of riot.compile I introduced a new bug: the inner unindent funcion (wich is fragile and limited, but functional) is not called for tags loaded by XHR (<script src="file" type="riot/tag">), so if the loaded tags does not start at column 0, the compiler can not find it.

Indentation inside the opening and closing html tags (internal) is irrelevant, except for the closing tag (</my-tag>). The compiler assume the first closing tag starting at column 0 is the desired closing tag.

Right now I'm reviewing the code of these routines. I will send a fix for riot.compile soon, and in the coming days I will try to solve the inconsistencies once and for all.

[GianlucaGuarini]

this issue was fixed http://jsfiddle.net/x9sakras/