Verify validator token manifest matches private key #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachase
reviewed
Nov 15, 2017
| @@ -42,9 +42,23 @@ ValidatorKeys::ValidatorKeys(Config const& config, beast::Journal j) | |||
| if (auto const token = ValidatorToken::make_ValidatorToken( | |||
There was a problem hiding this comment.
Looks like the non-unity build wants #include <beast/core/detail/base64.hpp>
Codecov Report
@@ Coverage Diff @@
## develop #2268 +/- ##
===========================================
- Coverage 70.11% 70.09% -0.02%
===========================================
Files 689 689
Lines 50800 50806 +6
===========================================
- Hits 35617 35615 -2
- Misses 15183 15191 +8
Continue to review full report at Codecov.
|
scottschurr
approved these changes
Nov 16, 2017
wilsonianb
force-pushed
the
verify-token
branch
from
7362ee3
to
ee4351d
Compare
wilsonianb
added
the
Passed
Reject manifest with invalid public key type RIPD-1560
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw error if validator token key does not match manifest