Update macos build instructions: #2342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added workaround for include path order anomaly with Xcode (discovered while testing the xcode build instructions)
Jenkins Build SummaryBuilt from this commit Built at 20180124 - 00:41:54 Test Results
|
HowardHinnant
approved these changes
Jan 19, 2018
|
FWIW, the github rendered version of this document is here: https://github.com/mellery451/rippled/tree/mellery-macos-readme/Builds/macos (if that makes it easier to review) |
scottschurr
approved these changes
Jan 23, 2018
Builds/macos/README.md
Outdated
| ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" | ||
| ``` | ||
|
|
||
| For more info, see "Step 3: Install Homebrew" |
There was a problem hiding this comment.
I think that should read, `see "Step 2: Install Homebrew".
There was a problem hiding this comment.
good catch - I fixed the link and the text.
mellery451
added
the
Passed
manojsdoshi
reviewed
Jan 24, 2018
|
In 0.90.0-b5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workaround for include path order anomaly with Xcode (discovered
while testing the xcode build instructions)