Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent error messages - "lgrNotFound" and "ledgerNotFound" #3654

Open
carlhua opened this issue Nov 5, 2020 · 1 comment
Open

Inconsistent error messages - "lgrNotFound" and "ledgerNotFound" #3654

carlhua opened this issue Nov 5, 2020 · 1 comment
Labels
API Change Bug Good First Issue Great issue for a new contributor Potential Bounty Idea Reviewed RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements Will Need Documentation

Comments

@carlhua
Copy link
Contributor

carlhua commented Nov 5, 2020

An RPC command could return two different error messages meaning the same thing, either ledgerNotFound or lgrNotFound. There are also some unit tests that care about these values. In addition, it seems that the improved ledger_request response switched from "ledgerNotFound" to "lgrNotFound". We should consolidate these to use the same error.

Here are some examples of inconsistency:

https://github.com/ripple/rippled/blob/0b4e34b03b72196510998375fd28622c8b63aaa7/src/ripple/protocol/impl/ErrorCodes.cpp#L83

https://github.com/ripple/rippled/blob/0b4e34b03b72196510998375fd28622c8b63aaa7/src/ripple/rpc/handlers/CanDelete.cpp#L83

Exported from RIPD-1080
@carlhua carlhua added Bug RIPD Export Exported from legacy JIRA issue tracking Reviewed Low Priority labels Nov 5, 2020
@intelliot intelliot added Good First Issue Great issue for a new contributor Tech Debt Non-urgent improvements Potential Bounty Idea Will Need Documentation and removed Low Priority labels May 23, 2023
@intelliot
Copy link
Collaborator

This may be something to clean up in Clio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Change Bug Good First Issue Great issue for a new contributor Potential Bounty Idea Reviewed RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements Will Need Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@intelliot @mDuo13 @carlhua