Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add semver check in CI #167

Closed
skyzh opened this issue Feb 16, 2023 · 3 comments · Fixed by #168
Closed

ci: add semver check in CI #167

skyzh opened this issue Feb 16, 2023 · 3 comments · Fixed by #168

Comments

@skyzh
Copy link
Member

skyzh commented Feb 16, 2023

I feel I cannot catch all API changes during my review, and it would be a good idea to use a tool in this case 🤪
@skyzh
Copy link
Member Author

skyzh commented Feb 16, 2023

Okay we did accidentally break something. We will need to bump to 0.13 instead of 0.12.1.

@skyzh skyzh mentioned this issue Feb 16, 2023
Merged
@melgenek
Copy link
Contributor

Okay we did accidentally break something. We will need to bump to 0.13 instead of 0.12.1.

I am sorry that I didn't mention a new function parameter explicitly. I wasn't sure how strict the releases in this library are in terms of api compatibility.

Thank you for taking care of this issue!

@skyzh
Copy link
Member Author

skyzh commented Feb 16, 2023

No worries! I think we also didn't take this seriously for a long time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: bump to v0.13.0 risinglightdb/sqllogictest-rs
2 participants
@melgenek @skyzh