fix(bin): do not print stack backtrace on error #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TennyZhuang
approved these changes
Jul 31, 2023
... because it's totally noise for users Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
added a commit
that referenced
this pull request
Aug 21, 2023
revert #189. Error context is printed only for `{:?}`. For backtrace, according to anyhow's doc, > If using the nightly channel, or stable with features = ["backtrace"], a backtrace is captured and printed with the error if the underlying error type does not already provide its own. In order to see backtraces, they must be enabled through the environment variables described in std::backtrace So we can either: ship pre-built binary or unset `RUST_BACKTRACE` to hide backtrace.
xxchan
added a commit
that referenced
this pull request
Aug 21, 2023
revert #189. Error context is printed only for `{:?}`. For backtrace, according to anyhow's doc, > If using the nightly channel, or stable with features = ["backtrace"], a backtrace is captured and printed with the error if the underlying error type does not already provide its own. In order to see backtraces, they must be enabled through the environment variables described in std::backtrace So we can either: ship pre-built binary or unset `RUST_BACKTRACE` to hide backtrace. Signed-off-by: xxchan <xxchan22f@gmail.com>
TennyZhuang
pushed a commit
that referenced
this pull request
Aug 21, 2023
* fix error context display revert #189. Error context is printed only for `{:?}`. For backtrace, according to anyhow's doc, > If using the nightly channel, or stable with features = ["backtrace"], a backtrace is captured and printed with the error if the underlying error type does not already provide its own. In order to see backtraces, they must be enabled through the environment variables described in std::backtrace So we can either: ship pre-built binary or unset `RUST_BACKTRACE` to hide backtrace. Signed-off-by: xxchan <xxchan22f@gmail.com> * update release workflow Signed-off-by: xxchan <xxchan22f@gmail.com> * test release ci Signed-off-by: xxchan <xxchan22f@gmail.com> * add changelog Signed-off-by: xxchan <xxchan22f@gmail.com> * add more targets Signed-off-by: xxchan <xxchan22f@gmail.com> * more cargo-binstall friendly Signed-off-by: xxchan <xxchan22f@gmail.com> * remove test config Signed-off-by: xxchan <xxchan22f@gmail.com> --------- Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because it's totally noise for users