Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default values of the system parameters, and where to configure the values #660

Closed
hengm3467 opened this issue Mar 20, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@hengm3467
Copy link
Collaborator

Related code PR

risingwavelabs/risingwave#8623

Which part(s) of the docs might be affected or should be updated? And how?

Manage RisingWave -> Vieww and adjust system parameters

@Gun9niR As I understand it, we'll need to mention two things:

  1. The default/initial values out of box (without customization by users)
  2. Where to customize/specify the initial values

Correct? Or only the latter would be fine?

Thanks.

Reference

No response

@hengm3467 hengm3467 added the documentation Improvements or additions to documentation label Mar 20, 2023
@Gun9niR
Copy link

Gun9niR commented Mar 20, 2023

I think both are required. Some notes:

  • While we can initialize the initial values from the config file (the [system] section), it is only for CI purposes and should not be used by the user.
  • Immutable params can be initialized from CLI, e.g. state_store corresponds to --state-store and environment variable RW_STATE_STORE
  • Mutable params can only be initialized with the default value. The user can modify it later with ALtER SYSTEM.

@hengm3467
Copy link
Collaborator Author

--> Immutable params can be initialized from CLI, e.g. state_store corresponds to --state-store and environment variable RW_STATE_STORE

@Gun9niR Can you share more information about how to do this? Thanks!

@Gun9niR
Copy link

Gun9niR commented Mar 24, 2023

The reason that immutable params need to be initialized from CLI is due to their immutability, ALTER SYSTEM SET on them will fail.

So we need to initialize them from command line arguments. For example, state_store is one of these immutable params, so to initialize it, one can add an argument --state-store=hummock-memory after the meta node command. Once the cluster is up, the user is not allowed to change it. One can also specify the environment variable RW_STATE_STORE to initialize it, which overrides CLI argument.

Once the cluster is started, the system parameters are persisted to meta store (etcd). If the meta node is restarted with different initial values for these params, they will just be ignored, and a warning message will be emitted.

@hengm3467 hengm3467 assigned hengm3467 and unassigned CharlieSYH May 18, 2023
@hengm3467
Copy link
Collaborator Author

Fixed in #981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants