-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch: singleton seq scan on local mode #4164
Labels
component/batch
Batch related related issue.
help wanted
Issues that need help from contributors
type/bug
Something isn't working
Comments
BugenZhao
added
type/bug
Something isn't working
help wanted
Issues that need help from contributors
component/batch
Batch related related issue.
labels
Jul 26, 2022
@xxchan Could you please help to take a look? |
3 tasks
Well this problem is hard to find cuz the execution works fine and we can get the results. 👍 |
Agreed that HashShard(vec![]) should not be a valid expression in our system. |
This is a known issue, another case the table scan maybe singleton is partition prunning. |
I think we should fix it in fragmenter, since we will move root fragment execution into frontend later. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/batch
Batch related related issue.
help wanted
Issues that need help from contributors
type/bug
Something isn't working
Describe the bug
Currently, when scanning from a singleton mview, we still schedule multiple scans.
To Reproduce
The distribution is
[]
, that is,HashShard
with empty keys. This is incorrect, we should useSingle
instead.https://github.com/singularity-data/risingwave/blob/eb8109fc122ad51a8ccfcf4fc1efc03d79bfdb0a/src/frontend/src/optimizer/plan_node/batch_seq_scan.rs#L75-L93
#4153 introduced a fix while commented out, since it won't work on local mode now. We should fix this.
Expected behavior
Additional context
#4153 fixes the similar issue of
StreamScan
.#3269 is related.
The text was updated successfully, but these errors were encountered: