From 4c7d174ada588a6e0d5cb47b93cf0e8e2e7c0881 Mon Sep 17 00:00:00 2001 From: Bugen Zhao Date: Fri, 29 Nov 2024 11:46:52 +0800 Subject: [PATCH] fix: bypass cluster limits by default in debug build --- src/common/src/session_config/mod.rs | 5 ++++- src/config/ci-sim.toml | 4 ---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/common/src/session_config/mod.rs b/src/common/src/session_config/mod.rs index 7595ceeb21a7..a141c9c45269 100644 --- a/src/common/src/session_config/mod.rs +++ b/src/common/src/session_config/mod.rs @@ -58,6 +58,9 @@ type SessionConfigResult = std::result::Result; const DISABLE_BACKFILL_RATE_LIMIT: i32 = -1; const DISABLE_SOURCE_RATE_LIMIT: i32 = -1; +/// Default to bypass cluster limits iff in debug mode. +const BYPASS_CLUSTER_LIMITS: bool = cfg!(debug_assertions); + #[serde_as] /// This is the Session Config of RisingWave. #[derive(Clone, Debug, Deserialize, Serialize, SessionConfig, ConfigDoc, PartialEq)] @@ -306,7 +309,7 @@ pub struct SessionConfig { /// Bypass checks on cluster limits /// /// When enabled, `CREATE MATERIALIZED VIEW` will not fail if the cluster limit is hit. - #[parameter(default = false)] + #[parameter(default = BYPASS_CLUSTER_LIMITS)] bypass_cluster_limits: bool, /// The maximum number of parallelism a streaming query can use. Defaults to 256. diff --git a/src/config/ci-sim.toml b/src/config/ci-sim.toml index 30a2b00f7368..9535ff83696c 100644 --- a/src/config/ci-sim.toml +++ b/src/config/ci-sim.toml @@ -7,7 +7,3 @@ max_concurrent_creating_streaming_jobs = 0 [meta] meta_leader_lease_secs = 10 - -[meta.developer] -meta_actor_cnt_per_worker_parallelism_soft_limit = 65536 -meta_actor_cnt_per_worker_parallelism_hard_limit = 65536 \ No newline at end of file