Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly dependencies #15

Open
3 of 7 tasks
ErichDonGubler opened this issue Dec 29, 2017 · 5 comments
Open
3 of 7 tasks

Remove nightly dependencies #15

ErichDonGubler opened this issue Dec 29, 2017 · 5 comments
Assignees
Milestone

Comments

@ErichDonGubler
Copy link
Collaborator

ErichDonGubler commented Dec 29, 2017

This issue will probably be pretty long-lived, as there are several features we use that rely upon nightly:

  • #![feature(const_fn)]
  • #![feature(fnbox)]
  • #![feature(libc)] <- perhaps we could fix this by using the libc crate?
  • #![feature(refcell_replace_swap)] <- waiting for landing in stable
  • #![feature(trace_macros)] <- This could probably be removed easily.
  • #![feature(alloca)] <- We almost certainly don't actually need this...
  • mozjs is currently nightly-only.
@ricochet1k
Copy link
Contributor

trace_macros doesn't need to stay there, it is only used occasionally for macro debugging.
fnbox is used in a few places because it seems impossible to send fns across thread boundaries otherwise.
refcell_replace_swap is probably not necessary.
I don't remember what const_fn is, and I don't know anything about libc.

@ErichDonGubler
Copy link
Collaborator Author

@ricochet1k: const_fn is being used in a few places (looks like mostly jsclass.rs) -- not sure if we need it yet.

@ErichDonGubler
Copy link
Collaborator Author

@ricochet1k: refcell_replace_swap is going to land in stable soon -- it looks like it'll enter beta with the next release: rust-lang/rust#46517

@ErichDonGubler
Copy link
Collaborator Author

Added alloca, since I see that was added.

Seems like we don't really need it, though?

@sagudev
Copy link
Contributor

sagudev commented Jan 18, 2020

I think this issue can be closed now. #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants