Move interface definitions into packing modules. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides the internal module names when we export types.
This prevents a separate Probabilities module in Interfaces
|
While this PR ultimately did not use module aliases (I ran out of allocated time towards build system hacking, and I still don't understand this OCaml feature fully), it did address my original goal for #182, of having the appropriate type/module nesting between Oml and Oml_full. |
This was referenced Feb 20, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the internal module names when we export types.
Also adding a
make showedtarget to dump the entire exported interfaces. This is not a robust solution, at the moment, as the module targets are hard coded and not automatically generated.