Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEARLWorker #2310

Open
braunjon opened this issue Nov 20, 2021 · 0 comments
Open

PEARLWorker #2310

braunjon opened this issue Nov 20, 2021 · 0 comments

Comments

@braunjon
Copy link

braunjon commented Nov 20, 2021

Hi, I have two issues that I do not quite understand why they are part of the code

  1. The code overwrites the action a in the deterministic case:

    a, agent_info = self.agent.get_action(self._prev_obs)
    if self._deterministic:
    a = agent_info['mean']
    a, agent_info = self.agent.get_action(self._prev_obs)

    There is an open pull request about this here: Fix double action sampling in PEARLWorker #2275.

  2. I was wondering if the context is ever used in self.agent. As far as I understand in the pearl.py file we never use the context of self._policy and it is also not used within the class ContextConditionedPolicy.

    if self._accum_context:
    s = TimeStep.from_env_step(env_step=es,
    last_observation=self._prev_obs,
    agent_info=agent_info,
    episode_info=self._episode_info)
    self.agent.update_context(s)

Some hints are appreciated
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant