New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation detail question about MAMLPPO #2331

Open

seolhokim opened this issue Aug 2, 2022 · 0 comments

seolhokim commented Aug 2, 2022 •

edited

Loading

Hi, Thank you for providing the quality code. I have a implementation detail question.

Why don't you just call optimizer.step() after meta_objective.backward()?

garage/src/garage/torch/algos/maml.py

Lines 124 to 127 in f056fb8

    
           self._meta_optimizer.zero_grad() 
        
           meta_objective.backward() 
        
           self._meta_optimize(all_samples, all_params)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment