Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

State resetting for the tighten/ziggy package #63

Closed
butschster opened this issue Sep 10, 2021 · 6 comments · Fixed by #64
Closed

State resetting for the tighten/ziggy package #63

butschster opened this issue Sep 10, 2021 · 6 comments · Fixed by #64
Assignees
Labels
type:enhancement New feature or request

Comments

@butschster
Copy link
Contributor

Сейчас при после пары обновлений страницы при использовании Jetstream с InertiaJs появляется ошибка.

Uncaught ReferenceError: Ziggy is not defined
Uncaught (in promise) ReferenceError: route is not defined

Причина ошибки связана с пакетом tightenco/ziggy в классе Tightenco\Ziggy\BladeRouteGenerator.

Сброс состояния в BladeRouteGenerator::$generated = false решает проблему.

@butschster butschster added the type:bug Something isn't working label Sep 10, 2021
@butschster
Copy link
Contributor Author

Чуть позже могу залить PR

@SerafimArts
Copy link

PR с чем? Этот пакет не имеет ничего общего с tightenco/ziggy.

@butschster
Copy link
Contributor Author

PR с чем? Этот пакет не имеет ничего общего с tightenco/ziggy.

Ну так этот пакет входит в состав Jetstream, это поддержка для этого пакета

@tarampampam
Copy link
Collaborator

laravel/jetstream does not requires tighten/ziggy (or this is a "hidden" dependency?). Anyway, ziggy looks like a popular package, and if you need in "resetter" - we can implement it 😃

@tarampampam tarampampam added type:enhancement New feature or request and removed type:bug Something isn't working labels Sep 12, 2021
@tarampampam tarampampam changed the title Сброс состояния для Jetstream State resetting for the tighten/ziggy package Sep 12, 2021
@tarampampam
Copy link
Collaborator

ping @butschster

@butschster
Copy link
Contributor Author

laravel/jetstream does not requires tighten/ziggy (or this is a "hidden" dependency?). Anyway, ziggy looks like a popular package, and if you need in "resetter" - we can implement it 😃

Yes, laravel/jetstream has a hidden dependency on tighten/ziggy (You can find it here https://github.com/laravel/jetstream/blob/2.x/src/Console/InstallCommand.php#L283). As I understand this package is quite popular among Laravel arisans. It would be a good decision to add support for this package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants