Speed up the mercurial plugin for large repositories #4399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he git plugin In some very large repositories, `hg status` can take a pretty long time. It doesn't feel great to have a multi second delay every time you run a command while you wait for hg status to complete. Mirroring the functionality in the git plugin, this diff adds a check for a new configuration option in `hg config`. If this option is enabled we disable the `hg status` check and just show the clean marker.
…pers The helper functions are smart only work if the user is in an hg repository. Unfortunately checking that fact can take a while for large repos, so these redundant checks are taking a while. This diff stores the result of the first call from `hg_prompt_info` in a local variable and just checks that for every other function. This gave me a multi-second speedup locally.
|
Ping. Any chance of this going in? I've been using it locally for a while, but I'd like to bring my local checkout back in line with oh-my-zsh master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very large repositories, certain hg commands can take a very long time. Two of those used in the mercurial plugin are particularly bad -
hg statusandhg summary. I removed thehg summarycall by replacing it withhg root, which gives us similar information much faster.hg statuswas a different beast, and since there is no "faster" replacement I ended up just mirroring the functionality of the git plugin. If you're unfamiliar, the git plugin simply shows the clean prompt if a certain config flag is set (oh-my-zsh.hide-dirty). This approach has multiple benefits, the most important being that you can configure it per-repository.Finally, the multiple
in_hgcalls ended up callinghg roota lot. These were not super long calls on their own, but when we do it often we end up spending quite a bit of time calculating an answer we already know. To fix this I saved it in a local variable at the beginning of thehg_prompt_infocall and remove it at the end.