Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Wait Until Location Is" error message reads "Location did not is <url> in <wait time>" #1559

Closed
testventure opened this issue Mar 10, 2020 · 3 comments
Closed

"Wait Until Location Is" error message reads "Location did not is <url> in <wait time>" #1559

testventure opened this issue Mar 10, 2020 · 3 comments
Labels
acknowledge To be acknowledged in release notes bug priority: medium rc 1
Milestone
v4.4.0

Comments

@testventure
Copy link

testventure commented Mar 10, 2020 •
edited
Loading

Steps to reproduce the issue:
Give "Wait Until Location Is" a parameter that will fail.

Observed: Location did not is (url) in (wait time)
Expected: Something like:

  • Location did not become (url) in (wait time)
  • Location did not change to (url) in (wait time)
@aaltat
Copy link
Contributor

aaltat commented Mar 10, 2020

Good catch, the error message definitely needs improving. Would you like to make a PR to fix it?

@testventure
Copy link
Author

Sure I'm willing to do that.

@aaltat aaltat mentioned this issue Mar 12, 2020
Merged
@aaltat
Copy link
Contributor

aaltat commented Mar 12, 2020

Fixed in #1560

@aaltat aaltat closed this as completed Mar 12, 2020
@aaltat aaltat added this to the v5.0.0 milestone Mar 12, 2020
@aaltat aaltat added acknowledge To be acknowledged in release notes bug priority: medium labels Mar 12, 2020
@aaltat aaltat added the rc 1 label Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledge To be acknowledged in release notes bug priority: medium rc 1
Projects
None yet
Milestone
v4.4.0
Development

No branches or pull requests
2 participants
@aaltat @testventure