Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMCFOC – Port latest dev from AMCBLDC project #74

Closed
pattacini opened this issue Jan 8, 2024 · 4 comments · Fixed by #79
Closed

AMCFOC – Port latest dev from AMCBLDC project #74

pattacini opened this issue Jan 8, 2024 · 4 comments · Fixed by #79
Assignees
Labels
domain-modeling Pertains to model-based design team-fix Activity performed by Team FIX type-board-amcfoc Relevant to the AMCFOC development

Comments

@pattacini
Copy link
Member

pattacini commented Jan 8, 2024

This is a follow-up of #73 to address these points below:

  • Vcc is now an input.
  • CMSIS vs. STD variant (it's ok to keep the variant, eventually).
  • Variant for the Thermal Model.

cc @Nicogene

@pattacini pattacini added team-fix Activity performed by Team FIX domain-modeling Pertains to model-based design type-board-amcfoc Relevant to the AMCFOC development labels Jan 8, 2024
@mfussi66
Copy link
Member

mfussi66 commented Jan 29, 2024

Showing here the modifications I made to address this issue:

* `Vcc` is now an input.

Just added Vcc as a input as requested. Sensors is filled from outside the simulink model:

image

* CMSIS vs. STD variant (it's ok to keep the variant, eventually).

Done ✅

image

* Variant for the Thermal Model.

Similarly to the amcbldc, I created a variant configuration:

image

Which influences the RMS computation

image

And disables the temperature estimation:

image

The referenced model is inside the variant subsystem:

image

@pattacini
Copy link
Member Author

Nice!

@pattacini pattacini linked a pull request Jan 29, 2024 that will close this issue
@mfussi66
Copy link
Member

PR here! #79

@pattacini
Copy link
Member Author

Merged ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-modeling Pertains to model-based design team-fix Activity performed by Team FIX type-board-amcfoc Relevant to the AMCFOC development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants