Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarpdataplayer: cannot load data dump with 1 entry #936

Closed
gsaponaro opened this issue Oct 24, 2016 · 4 comments
Closed

yarpdataplayer: cannot load data dump with 1 entry #936

gsaponaro opened this issue Oct 24, 2016 · 4 comments

Comments

@gsaponaro
Copy link
Contributor

Hi @vtikha, I would like to use a data dump with exactly 1 entry of image type. I recorded it with yarpdatadumper (download link at the bottom), but when I try to load it in yarpdataplayer I get this error

There was a problem reading
data.log
please check its validity

I looked at the function Utilities::checkLogValidity(const char *filename) in utils.cpp which raises that error. While the file info.log passes the check (because it has 2 lines), data.log fails it (1 line).

One quick way to fix would be to change L229 from

            if (itr >= 1){

to

            if (itr >= 0){

(Or remove altogether the if: L229 and L235.)

BTW, this is not urgent for me, I'm running the modification locally. Just wanted to make you aware of this corner case. :) Let me know if I should submit a PR.

PS: the data was acquired with yarpdatadumper --name /left --connect /icub/camcalib/left/out --type image --downsample 30 and hitting ctrl+c after 1 second. Here is the download link.

@vtikha
Copy link
Member

vtikha commented Oct 26, 2016

yarpdataplayer can now replay a one image dataset.

@drdanz
Copy link
Member

drdanz commented Oct 26, 2016

Fixed in 0307c0e

@gsaponaro
Copy link
Contributor Author

Thanks!

@drdanz
Copy link
Member

drdanz commented Oct 26, 2016

And in a7f51e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants