Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all instances of roc_ls and roc_lang_server to roc_language_server #6330

Closed
Anton-4 opened this issue Jan 1, 2024 · 5 comments · Fixed by #6352
Closed

Rename all instances of roc_ls and roc_lang_server to roc_language_server #6330

Anton-4 opened this issue Jan 1, 2024 · 5 comments · Fixed by #6352
Assignees
Labels
good first issue Good for newcomers

Comments

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 1, 2024

Descriptive names are better :)

@Anton-4 Anton-4 added the good first issue Good for newcomers label Jan 1, 2024
@ayazhafiz
Copy link
Member

Let's go either fully to roc_language_server or stick with roc_ls. I chose roc_ls because it's short and the LS suffix is well known; for example Haskell has hls, Go has gopls, OCaml has ocamllsp. Also, long term people shouldn't be really using this on the frontend; you should favor an editor extension.

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Jan 1, 2024

roc_language_server is good for me 👍
I'd guess the LS suffix is well known among experienced programmers but I'd bet it's not very familiar to people with a few years of programming experience or less.

Also, long term people shouldn't be really using this on the frontend

I agree, but even if roc_ls was only used in our code base I would prefer a more descriptive name. I like to remove friction to understanding the code base wherever possible. Only if a name is e.g. used frequently in a small section of code does the decrease in clutter (because of the shorter name) start to be worth it.

@Anton-4 Anton-4 changed the title Rename roc_ls to roc_lang_server everywhere Rename all instances of roc_ls and roc_lang_server to roc_language_server Jan 1, 2024
@B-Teague
Copy link
Contributor

B-Teague commented Jan 2, 2024

I wanted to pick this up as my first contribution to roc-lang (unless ayazhafiz is already working on it), but I wanted to ask this first?

For consistency, should I do roc_lang_server instead of roc_language_server?
website is roc-lang.org
github is repo is roc-lang

Just wanted to confirm before I start making all the changes.

@ayazhafiz
Copy link
Member

Let's do roc_language_server.

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Jan 3, 2024

Thanks for helping out @B-Teague :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants