Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition test template is wrong #266

Open
henriquejsfj opened this issue Oct 19, 2020 · 1 comment
Open

Composition test template is wrong #266

henriquejsfj opened this issue Oct 19, 2020 · 1 comment

Comments

@henriquejsfj
Copy link

Hello guys,
The composition test template has this part there:

# sample =
#     expect_execution do
#         syskit_write cmp_task.my_child.an_output_port, test_sample
#     end.to { have_one_new_sample cmp_task.my_child.an_input_port }

I guess it is wrong because it is writing to an output port and reading from an input port. In the composition, test context should be the opposite, so I suggest that:

# sample =
#     expect_execution do
#         syskit_write cmp_task.my_child.an_input_port, test_sample
#     end.to { have_one_new_sample cmp_task.my_child.an_output_port }

I didn't find where to fix it.

@henriquejsfj
Copy link
Author

@doudou ping

@henriquejsfj henriquejsfj closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@doudou doudou reopened this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants