Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFL season page URL changed #251

Closed
DavidLiuGit opened this issue Nov 12, 2019 · 2 comments
Closed

NFL season page URL changed #251

DavidLiuGit opened this issue Nov 12, 2019 · 2 comments
Assignees
@DavidLiuGit
Labels
bug Something isn't working
Milestone
Release 0.4.7

Comments

@DavidLiuGit
Copy link
Contributor

Describe the bug
SEASON_PAGE_URL should be updated

To Reproduce

from sportsreference.nfl.teams import Teams
teams = Teams(2018)

Change required:

SEASON_PAGE_URL = 'http://www.pro-football-reference.com/years/%s/'
# SEASON_PAGE_URL = 'http://www.pro-football-reference.com/years/%s.html'

#250
@roclark roclark added the bug Something isn't working label Nov 13, 2019
@roclark roclark added this to the Release 0.4.7 milestone Nov 13, 2019
@roclark
Copy link
Owner

roclark commented Nov 13, 2019

Thanks for this issue as well @DavidLiuGit! I will review #250 and let you know what I think! Should be pretty straightforward, and I want to get this in quickly.

@roclark
Copy link
Owner

roclark commented Nov 14, 2019

Closing this with the acceptance of #250. Thanks again for bringing this up and for the fix!

@roclark roclark closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidLiuGit DavidLiuGit

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.4.7
Development

No branches or pull requests
2 participants
@roclark @DavidLiuGit