Fix for ignored forge URL when using APIv3 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giavjeko
changed the title
carlossg
added a commit
that referenced
this pull request
Oct 10, 2014
Fix for ignored forge URL when using APIv3
|
Thanks |
carlossg
pushed a commit
that referenced
this pull request
Oct 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo for APIv3 is using PuppetForge as API client. PuppetForge is using https://forgeapi.puppetlabs.com remote URL by default. So, if you set custom forge URL in Puppetfile and run librarian-puppet with --no-use-v1-api, it will ignore your forge URL and use official forge.
I have added constructor for repo v3 which sets PuppetForge remote URL.
@rodjek, are you interested in merging this?