Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting radius variations with multi-wavelength maps #286

Open
taylorbell57 opened this issue Jul 8, 2021 · 5 comments
Open

Fitting radius variations with multi-wavelength maps #286

taylorbell57 opened this issue Jul 8, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@taylorbell57
Copy link

Is your feature request related to a problem? Please describe.
The multi-wavelength feature does not allow one to fit for differences in the radius ratio at different wavelengths. This makes fitting a JWST phase curve or transit with starry an impossible task without fitting each wavelength independently (which comes at a huge computation cost).

Describe the solution you'd like
The r value for secondary objects should accept array-like inputs in a similar manner to map.y

@taylorbell57 taylorbell57 added the enhancement New feature or request label Jul 8, 2021
@taylorbell57
Copy link
Author

Hi @rodluger, is this a feature you have looked into at all? I'm looking to do simultaneous, multi-wavelength fitting of JWST phase curves and need to be able to fit for the transmission spectra. Do you have a feel for how easy/hard this would be to implement? If it is likely to be fairly easy (a day or few of work) but you simply don't have the time, I might be able to spend some time on it myself

@rodluger
Copy link
Owner

rodluger commented Apr 8, 2022

Hmm. It's certainly doable but not easy given the way the code is structured. But I can certainly help you write a workaround script (and we can think about implementing it in starry later). Can you give me a MWE of the computationally expensive way you're currently going about it with starry?

@taylorbell57
Copy link
Author

I haven't actually implemented it yet, but the only alternative I could think of was for N wavelengths making N primary, N secondary, and N system objects and using the same orbital parameters for all those objects while each would have different planetary radius, amp, and map coefficients. I haven't tried that to see how slow it actually is, but I can't imagine that would perform well and it wouldn't take advantage of the other already-written capabilities for multi-wavelength computations

@dfm
Copy link
Collaborator

dfm commented Apr 11, 2022

This is something I've been working on a little bit and I have thoughts! I'm not using starry directly, or really fitting phase curves, I've mostly been thinking about robust but tractable methods for fitting the radius ratio variations. I'm hoping to sketch this out somewhere soon, but I don't have anything sensible written down to share yet. The basic idea is that I linearize the model in Rp/Rs (and, in my case, limb darkening params) around a fiducial model, which allows me to infer the radius variations without introducing all these extra parameters. I expect something like this could play nice with starry, but @rodluger might have cleverer ideas within the existing framework!

@catrionamurray
Copy link

catrionamurray commented Jun 9, 2023

Hi! Just wondering if there's been any update on this issue? I also have an interest in vectorizing $r_p$ and I'm currently having to create N starry systems (as Taylor suggests), one for each wavelength (doable just very slow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants