You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, thank you for this project and for making it open-source!
I realize some benefits of assert statements in source code. However, looking at some SO answers, for example here, I wonder if it would be a good idea to remove assert statements and instead convert them into their own unit tests inside the tests directory.
Some of the assert statements do not seem to have an explicit error message. So maybe, either assert statements could be coupled with an explicit message or they could be removed, and instead, unit tests could be added.
It would be interesting to know any thoughts/suggestions on this.
Thanks!
The text was updated successfully, but these errors were encountered:
Hello, thank you for this project and for making it open-source!
I realize some benefits of assert statements in source code. However, looking at some SO answers, for example here, I wonder if it would be a good idea to remove assert statements and instead convert them into their own unit tests inside the
tests
directory.Some of the
assert
statements do not seem to have an explicit error message. So maybe, either assert statements could be coupled with an explicit message or they could be removed, and instead, unit tests could be added.It would be interesting to know any thoughts/suggestions on this.
Thanks!
The text was updated successfully, but these errors were encountered: