Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting assert statements to unit tests? #294

Open
Yash-10 opened this issue Sep 24, 2021 · 0 comments
Open

Converting assert statements to unit tests? #294

Yash-10 opened this issue Sep 24, 2021 · 0 comments

Comments

@Yash-10
Copy link

Yash-10 commented Sep 24, 2021

Hello, thank you for this project and for making it open-source!

I realize some benefits of assert statements in source code. However, looking at some SO answers, for example here, I wonder if it would be a good idea to remove assert statements and instead convert them into their own unit tests inside the tests directory.

Some of the assert statements do not seem to have an explicit error message. So maybe, either assert statements could be coupled with an explicit message or they could be removed, and instead, unit tests could be added.

It would be interesting to know any thoughts/suggestions on this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant