Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for no JS errors in IE8 and below #47

Merged
merged 2 commits into from
Apr 5, 2015

Conversation

zoltan-dulac
Copy link
Contributor

As per commentary in #46 , we fixed the js files so they would fail without JS errors. The only thing that appears in the console is a .info() call that states "This script will only work with browsers that have buggy implementations of viewport units and will not polyfill viewport units in older browsers (e.g. IE <= 8)'

If we want to take out the error message, that is fine. Otherwise, the issue has been resolved as per the commentary.

…E <= 8)

will get a friendly warning message instead of having JavaScript breaking
entirely.
@rodneyrehm
Copy link
Owner

LGTM. will prepare a release tomorrow. Thanks Zoltan!

rodneyrehm added a commit that referenced this pull request Apr 5, 2015
bugfix(init): prevent init for IE8 and below to avoid exception due to bad CSSOM
@rodneyrehm rodneyrehm merged commit c084e8a into rodneyrehm:master Apr 5, 2015
@rodneyrehm
Copy link
Owner

released in 0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants