-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade dropbox dependency from 7.x to 8 or 9 #142
Comments
Further info; I am migrating from pre-popup usage, and did not have a clientSecret. I am told to use PKCE, which I then set that parameter, and that then leads me to the fetch error. |
Basically, there could be multiple child windows(popups or iframes) all sending data back to the parent. So, there needs to be a check that the source window is the one we created. Additionally, the dropbox-sdk that is being required has a bug with fetch, that had to be worked around. There is also an undocumented requirement that the redirectUri must be specified, and that it must call dispatchMessage(). This needs to be better planned out. I implemented that myself directly in a react-router handler, and call window.opener.postMessage() inside a React.useEffect(). |
Hello, my apologies on how late this issue took to resolve. I have a diff up to upgrade the Dropbox dependency and have separated out the other issue mentioned to fix the multiple children and the redirectUri/call dispatch message issues here: #164 |
Hello @eigood, sorry for the delay in fixing the issue but the bug should be fixed as of version v3.1.0! |
I'm getting a 'unable to handle fetch' type error in dropbox.sdk.min.js, which seems to be solved in 8.1.
The text was updated successfully, but these errors were encountered: