From 2d9a0fd5eb9574b9c6efab0c0469a9de6cbd71bf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Katja=20Su=CC=88ss?= <k.suess@rohberg.ch>
Date: Thu, 31 Oct 2024 11:42:08 +0100
Subject: [PATCH] attac security issue

---
 .github/workflows/acceptance_monolingual.yml  | 3 +++
 .github/workflows/acceptance_multilingual.yml | 3 +++
 Makefile                                      | 4 ++++
 backend/dockerfiles/.env                      | 2 --
 4 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/acceptance_monolingual.yml b/.github/workflows/acceptance_monolingual.yml
index 3a8d560a..b1f1384e 100644
--- a/.github/workflows/acceptance_monolingual.yml
+++ b/.github/workflows/acceptance_monolingual.yml
@@ -57,6 +57,9 @@ jobs:
 
       - uses: JarvusInnovations/background-action@v1
         name: Start Servers
+        env:
+          INDEX_PASSWORD: ${{ secrets.SECRET_INDEX_PASSWORD}}
+          PLONE_PASSWORD: ${{ secrets.SECRET_PLONE_PASSWORD}}
         with:
           run: |
             make ci-acceptance-backend-start-monolingual &
diff --git a/.github/workflows/acceptance_multilingual.yml b/.github/workflows/acceptance_multilingual.yml
index f820bec2..f1f8f5a9 100644
--- a/.github/workflows/acceptance_multilingual.yml
+++ b/.github/workflows/acceptance_multilingual.yml
@@ -57,6 +57,9 @@ jobs:
 
       - uses: JarvusInnovations/background-action@v1
         name: Start Servers
+        env:
+          INDEX_PASSWORD: ${{ secrets.SECRET_INDEX_PASSWORD}}
+          PLONE_PASSWORD: ${{ secrets.SECRET_PLONE_PASSWORD}}
         with:
           run: |
             make ci-acceptance-backend-start-multilingual &
diff --git a/Makefile b/Makefile
index bb40144a..aebaf805 100644
--- a/Makefile
+++ b/Makefile
@@ -187,6 +187,8 @@ acceptance-frontend-prod-start-monolingual: ## Start acceptance frontend in prod
 
 .PHONY: acceptance-backend-start-monolingual
 acceptance-backend-start-monolingual: ## Start backend acceptance server
+    export INDEX_PASSWORD=paraDiesli,17
+    export PLONE_PASSWORD=secret
 	$(MAKE) -C "./backend/" acceptance-backend-start-monolingual
 
 .PHONY: ci-acceptance-backend-start-monolingual
@@ -215,6 +217,8 @@ acceptance-frontend-prod-start-multilingual: ## Start acceptance frontend in pro
 
 .PHONY: acceptance-backend-start-multilingual
 acceptance-backend-start-multilingual: ## Start backend acceptance server
+    export INDEX_PASSWORD=paraDiesli,17
+    export PLONE_PASSWORD=secret
 	$(MAKE) -C "./backend/" acceptance-backend-start-multilingual
 
 .PHONY: ci-acceptance-backend-start-multilingual
diff --git a/backend/dockerfiles/.env b/backend/dockerfiles/.env
index a52b3cea..dd00a54d 100644
--- a/backend/dockerfiles/.env
+++ b/backend/dockerfiles/.env
@@ -3,7 +3,6 @@ export INDEX_NAME=plone
 export INDEX_OPENSEARCH=1
 export INDEX_USE_SSL=1
 export INDEX_LOGIN=admin
-export INDEX_PASSWORD=paraDiesli,17
 
 export CELERY_BROKER=redis://redis:6379/0
 export CELERY_LOGLEVEL=info
@@ -11,7 +10,6 @@ export CELERY_LOGLEVEL=info
 export PLONE_SERVICE=http://backend-acceptance:55001
 export PLONE_SITE_PREFIX_PATH=plone
 export PLONE_USER=admin
-export PLONE_PASSWORD=secret
 
 export MAPPINGS_FILE=/configuration/mappings.json
 export ANALYSIS_FILE=/configuration/analysis.json