Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reporting #247

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Jan 12, 2023

Description of the change

This PR removes the requirement for users having to choose, investigate and use two separate crash collection frameworks by consolidating crash OS signal hooks, collection and reporting into the library. The mechanism by which we hook into the crash and exception flow has been rewritten.

Users of the Rollbar SDK shouldn't need to understand the technical aspects of crash collection, stack traces and reporting, that's why they choose to use an SDK that does all of this for them.

A lot of cleanup and removal of useless code has been done, which simplifies debugging and trying to find the issues we're seeing with error collection and missing stack traces.

This is a breaking change, since there are configuration requirements and entire libraries that are not needed any more to make the Rollbar Apple SDK work.

Demo projects have been updated accordingly.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jan 12, 2023
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't see anything that raised any questions

@matux matux merged commit 1fe2d01 into collect_crashes_with_stacktraces Jan 17, 2023
@matux matux deleted the simplify_reporting branch January 17, 2023 17:10
@matux matux mentioned this pull request Jan 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants