Remove faulty Out of Memory detection #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
There is no way to deterministically know if a crash occurred due to an out of memory error in iOS.
The current implementation uses some fuzzy logic to achieve this, but the false positives overweight the good:
Trying to detect this is a bad practice that's been dropped industry, and no crash reporting service has it as a feature simply because the OS will never report whether some crash is due to OOM.
Therefore, I'm removing this logic, and thus removing a large amount of complexity out of the codebase.
Type of change
Related issues
Checklists
Development
Code review