Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty Out of Memory detection #248

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jan 17, 2023

Description of the change

There is no way to deterministically know if a crash occurred due to an out of memory error in iOS.

The current implementation uses some fuzzy logic to achieve this, but the false positives overweight the good:

  1. Out of memory crashes are a very rare occurrence in iOS.
  2. We pretty much report that every crash "could" be due to OOM.
  3. The first time an app is installed and run, the code believes it crashed due to an OOM.

Trying to detect this is a bad practice that's been dropped industry, and no crash reporting service has it as a feature simply because the OS will never report whether some crash is due to OOM.

Therefore, I'm removing this logic, and thus removing a large amount of complexity out of the codebase.

  • This PR also fixes some broken tests that haven't been working for some time now.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested a review from ijsnow January 17, 2023 18:26
@matux matux self-assigned this Jan 17, 2023
@matux matux changed the base branch from master to collect_crashes_with_stacktraces January 17, 2023 18:26
@matux matux merged commit 82fbdc0 into collect_crashes_with_stacktraces Jan 17, 2023
@matux matux deleted the remove_oom branch January 17, 2023 18:40
@matux matux mentioned this pull request Jan 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants