Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollbar_flutter: Rollbar interface methods are overridden based on type of error object #93

Closed
TRemigi opened this issue Jan 20, 2023 · 2 comments · Fixed by #94
Closed

Comments

@TRemigi
Copy link

TRemigi commented Jan 20, 2023

Items logged using Rollbar.warn(), Rollbar.error(), and Rollbar.critical(), aren't categorized as the correct level depending on the type of the dynamic error argument.

For instance, if I execute Rollbar.warn('Test error', Stacktrace.empty);, the resulting item is set to the info level in my project. If I instead excecute Rollbar.warn(Exception('Test error'), Stacktrace.empty);, the item is correctly set to the warning level.

Similar things seem to happen when using Rollbar.error() - they end up being set to info if a String is passed, and warning if an Exception is passed. I assume the only way to get the result I would expect is to pass an Error object.

This behavior is bizarre and confusing, and on top of that the documentation provided no help when I began trying to find out why the items weren't the correct levels based on the methods I was using.

@ghost
Copy link

ghost commented Feb 9, 2023

Hey @TRemigi, Thanks for reporting this issue. We'll look into it and get back to you with an update.

@matux matux mentioned this issue Mar 7, 2023
12 tasks
@matux matux closed this as completed in #94 Mar 10, 2023
@matux
Copy link
Collaborator

matux commented Mar 15, 2023

@TRemigi

A new release fixing this issue is out now @ pub.dev:

I appreciate you reporting this issue, and if you find anything else, don't hesitate reporting, we'll do our best to take care of it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants