Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed connectivity monitor. #69

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Removed connectivity monitor. #69

merged 1 commit into from
Aug 9, 2022

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 9, 2022

Description of the change

I'm removing ConnectivityMonitor for the following reasons:

  • Flutter already has a connectivity monitoring mechanism.
  • ConnectivityMonitor doesn't provide actual connectivity monitoring in neither rollbar_common nor rollbar_dart.
  • Our CM doesn't add any features over Flutter's existent implementation.
  • It's not used internally.
  • Less code to maintain.
  • YAGNI

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 9, 2022
@matux matux requested a review from akornich August 9, 2022 20:11
@matux
Copy link
Collaborator Author

matux commented Aug 9, 2022

@akornich If you disagree, or I'm missing something, or would like to keep it, please do tell me!

Copy link
Contributor

@akornich akornich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming there will be a functional replacement to the ConnectivityMonitor

@matux matux merged commit 4b911fd into main Aug 9, 2022
@matux matux deleted the remove_cm branch August 9, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ConnectivityMonitor
2 participants