Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unix timestamp instead of java timestamp #88

Closed
mattdrees opened this issue Nov 27, 2017 · 4 comments
Closed

use unix timestamp instead of java timestamp #88

mattdrees opened this issue Nov 27, 2017 · 4 comments

Comments

@mattdrees
Copy link
Contributor

The API describes the timestamp field as a unix timestamp. However, rollbar-java's default TimestampProvider provides a "java" timestamp, which is based on milliseconds instead of seconds.

The rollbar UI doesn't seem to interpret this:
screen shot 2017-11-27 at 12 58 46 pm

I dislike how the api loses milliseconds, but it's probably best to be spec-compliant and divide the java timestamp by 1000 to dump the milliseconds.

@brianr
Copy link
Member

brianr commented Nov 27, 2017

Good find @mattdrees. I think we can probably keep the milliseconds on the "Notifier Timestamp" if rollbar-java sends it as a float. I believe it'll display without milliseconds on that "Notifier Timestamp" line, but the original value will be available in the Raw JSON section.

@rokob
Copy link
Contributor

rokob commented Nov 28, 2017

@brianr is that true? The fix here is to just send the value as a float or should we divide by 1000 to match the spec here: https://rollbar.com/docs/api/items_post/

@brianr
Copy link
Member

brianr commented Nov 28, 2017

@rokob ah sorry, I meant "divide by 1000 and send as a float".

@rokob
Copy link
Contributor

rokob commented Nov 28, 2017

Ah okay yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants