Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the code version for android #113

Merged
merged 1 commit into from
May 7, 2020

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented May 1, 2020

Fixes: #106

To enable Proguard support, allows setting the code version in AndroidManifest.xml:

<application>
  <!-- ... -->

  <meta-data android:name="com.rollbar.android.CODE_VERSION" android:value="1.0.0" />
</application>

#106 suggests adding to the arguments for init(), but this doesn't scale well as more config options are needed in the future, and method overloading for init() is unmanageable when all the args are the same type (String).

@waltjones waltjones requested a review from austenLacy May 4, 2020 17:41
@waltjones waltjones merged commit b38e8aa into master May 7, 2020
@waltjones waltjones deleted the wj-android-code-version branch January 26, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codeVersion to have able to upload ProGuard mapping.txt
2 participants