Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build with use_framework within CocoaPods #88

Merged
merged 1 commit into from
Nov 1, 2019
Merged

fix: build with use_framework within CocoaPods #88

merged 1 commit into from
Nov 1, 2019

Conversation

dozoisch
Copy link
Contributor

@dozoisch
fix: build with use_framework within CocoaPods
ccdf1d1 
- use_framework! is necessary for certain swift libraries and it makes certain header incompatible
- to fix that, use the same __has_include used for RCTBridgeModule on all the other imports
- tested on a fresh project without use_framework and a more involved project containing use_framework
- related https://github.com/facebook/react-native/pull/25393/files
@dozoisch
Copy link
Contributor Author

Once that is in. I can do a PR to update the react-native install steps with auto-linking.

@waltjones waltjones merged commit 98399b4 into rollbar:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dozoisch @waltjones