-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@rollup/plugin-node-resolve] Fix required versions of Node/Rollup in README + include these breaking changes in CHANGELOG #1222
Comments
It looks like node https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md#v900
It looks like rollup https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md#v1300
While technically these were both included in the CHANGELOG, they weren't particularly user friendly/obvious in their intent. In contrast, an earlier 'breaking changes' was very clear:
|
Similar story for #1245, which requires Rollup 2.78.0 now, but doesn't mention this in the CHANGELOG.md entry besides saying it's "breaking" in some way. The changelog is auto-generated, which encounters some issues where human intervention / readability is required, like in this case. I was looking to fix these (and the lack of hyperlinks to PRs in the Markdown) at one point in time too, but rather than a simple |
Folks, I really don't mean for this to be curt; if the lack of a hyperlink is stopping you from following the issue number, you may want to consider slowing down a tad, use the problem solving skills that got you into the industry to discern how to view the PR or issue number. In terms of blockers, that's the softest one I've ever seen. We'll update the script so it creates hyperlinks, but do try and take initiative to learn the platform you're using. |
Documentation Is:
Please Explain in Detail...
Your Proposal for Changes
The README and CHANGELOG should be kept up to date with breaking changes introduced in package versions, in end-user friendly descriptive language.
The text was updated successfully, but these errors were encountered: