Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub Actions #4

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Set up GitHub Actions #4

merged 5 commits into from
Apr 2, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 13, 2024

Copy link
Owner

@romainguy romainguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need a new plugin?

@Goooler
Copy link
Contributor Author

Goooler commented Mar 23, 2024

https://github.com/Goooler/kotlin-explorer/actions/runs/8399957453/job/23006686932

  • What went wrong:
    Could not determine the dependencies of task ':compileKotlinJvm'.
    No matching toolchains found for requested specification: {languageVersion=17, vendor=JETBRAINS, implementation=vendor-specific} for LINUX on x86_64.
    No locally installed toolchains match and toolchain download repositories have not been configured.

Add this plugin to ensure downloading proper Jetbrains JDKs, we can remove this plugin after removing

vendor = JvmVendorSpec.JETBRAINS

vendor = JvmVendorSpec.JETBRAINS

@romainguy
Copy link
Owner

No, we can’t remove those, this runtime is necessary.

@Goooler
Copy link
Contributor Author

Goooler commented Mar 23, 2024

So we need this plugin now, JBR vendor setups are blocked by actions/setup-java#399.

@romainguy romainguy merged commit 03c37c2 into romainguy:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants