Workaround for JBR JDK used by Compose Desktop Gradle Plugin #62
Conversation
| # TODO: replace this once https://github.com/actions/setup-java/pull/637 gets merged. | ||
| - uses: gmitch215/setup-java@99fc2135f7f7b08068e180cb5f29340f9de70720 |
There was a problem hiding this comment.
| # TODO: replace this once https://github.com/actions/setup-java/pull/637 gets merged. | |
| - uses: gmitch215/setup-java@99fc2135f7f7b08068e180cb5f29340f9de70720 | |
| - uses: actions/setup-java@v4 |
There was a problem hiding this comment.
This is not necessary here, we can revert the change, just ensure gmitch215/setup-java can be correctly used in .github/workflows/release.yml.
| java-version: 17 | ||
| - uses: gradle/actions/setup-gradle@v3 | ||
| - run: ./gradlew packageReleaseDmg | ||
| - run: ./gradlew build |
There was a problem hiding this comment.
The build task doesn't seem to run the "release" configuration and therefore doesn't run proguard on the jar files.
There was a problem hiding this comment.
As renameDmg depended on packageDmg instead of packageReleaseDmg, I correct it now.
Check https://github.com/Goooler/kotlin-explorer/actions/runs/9576053362/job/26401925728#step:5:58
| @@ -15,12 +15,13 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/setup-java@v4 | |||
| # TODO: replace this once https://github.com/actions/setup-java/pull/637 gets merged. | |||
| - uses: gmitch215/setup-java@99fc2135f7f7b08068e180cb5f29340f9de70720 | |||
There was a problem hiding this comment.
I'm not super comfortable with this. I'd rather have my own fork to make sure the action doesn't do anything unexpected in the future.
There was a problem hiding this comment.
Pinning on this commit or waiting for actions/setup-java#637 to be merged. Might hold this PR and release arm64 manually during these days.
|
Changed my mind, it's too painful without this. Thanks for the contribution @Goooler, it's very helpful! |
You can check the dists from https://github.com/Goooler/kotlin-explorer/actions/runs/9576053362, they works both on my M3 MBP now.